-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Link UI (<LinkControl>) Overview Issue #49091
Comments
Really nice work Saxon, I dig it. Do we actually need to show the permalink on the main link? To me the magic of a page is that it'll always link to the Page, no matter if its slug change. We already show the permalink on the subsequent page, so it seems unnecessary to show it in both places: And reducing the text here would not only benefit the information density (allowing more pages to show), but would benefit dyslexics and others. Finally, can we get the page-list tree-structure in there? I feel like it's a real limitation to only show the 3 most recent pages. When you build out your navigation, you'll constantly see those 3 same static pages, even if you have a structure of 20 to build. |
The tricky thing with icons is that different post types can have taxonomies with the same name. E.g. post categories and product categories. So if you have a "Pizza" post category and a "Pizza" product category, you'd need different icons in this UI to understand the difference, lest you end up with: I can't really see a way for core to cater to all custom taxonomies, and relying on plugins to supply icons could end up getting messy. Icons just seem much less scalable / reliable compared with text, but perhaps there's a smart solution for the icon issue that I'm not seeing? |
That's a fair point with regards to search, and if we need further differentiation there (such as slug), that seems fine, but to me the information density of being able to show almost double the amount of pages in the initial page filter seems worth it, no? |
If we aligned the context-chip horizontally with the title then the menu item footprints would be identical: We might not even need to display the context-chip / icon in the initial view given the 'Recent pages' heading. It's only really important when searching. |
I think we will also need to consider the a11y of using an icon alone. Why not combine icon for the "kind" and then text for the specific type? I guess it might be too much?
@jameskoster for these mockups would it be possible to include a variety of different titles for the results? Speaking from a long experience of working on this component, if we can add some variety it will help us iron out some of the problems that having long titles alongside long category names could expose.
We need some way to improve both the quantity and the quality of the results shown but also how these are displayed to the user. @SaxonF Thank you for the work on these designs. Much appreciated. Here are my thoughts such as they are:
|
cc'ing @alexstine and @joedolson for input on the accessibility of these proposed changes to the design of the Link UI. As they are currently in Figma only, if there's anything we can do to help to make these designs perceivable for you please let us know. |
Using only an icon to differentiate between different types of links is going to be very difficult to use, especially on large sites with a lot of taxonomies (as mentioned above.) I don't think it's worthwhile to display more items if the cost is the inability to distinguish which one is right. |
This should only be visible in navigation block and should add a page list block.
It should open this state where you can edit or remove the link, Clicking edit takes you back to the original state, pressing
Yep we can still show rich previews which would appear below token like we currently do.
This was based on recent feedback which does suggest it was too hidden for such a common action. @annezazu might be able to link to some of that feedback.
Some url validation probably makes sense although would there be edge cases to handle? e.g. localhost or #my-div
I missed some previous discussion around the addition of cancel/save but makes sense to me to only persist once "save" is hit. |
@jasmussen perhaps we show first 10 or so pages based on order? In future we can get smart with what suggestions we show e.g. for inline links default search is the text you've selected. I'd treat page suggestions as its own isolated task since recent is current behaviour. |
Definitely a separate issue, fine to iterate. But just thinking further ahead, it seems good to figure out whether we eventually show the tree view or always show the most recent items. For a static stie that hasn't had new pages created in a long time, it really feels awkward to see recent pages there. |
I definitely have sent folks to this issue who have mentioned how hidden open new is as a pain point and I myself have run into it! Let me tag in some folks from the WordPress.com side as they can often bring in at scale feedback (including some data that we can't get otherwise) to the project as a contribution. cc @jordesign @supernovia for any insights you can possibly share. |
Ah! Now I understand more about why these changes were made. I'm hoping they can be refined a bit. Here's a wildly popular forum topic on how to make links open in a new tab. People haven't previously asked support about this terribly often, but they do find that answer 10K+ times every month. Here's a video I made to show my before/after, if it helps (this video has sound, but you can see the before/after without sound if needed): adding.a.link.in.a.new.tab.movFrom our forums, about this update:
|
I have a few qualitative comments from folks running into this change as users on WordPress.com...
User effectively thought the feature was removed, rather than just 'moved'
|
Right so we need to consider making the Open in new tab visible at all times. Got it 👍 Btw this is additional evidence for why we need to consider revisions to the Link UI as a dedicated project rather than ad hoc efforts. That's what we're doing now with this Issue. |
Some additional design work happened at #49873 (comment). We need to unify this with the discovery undertaken here to ensure we're thinking holistically about the Link Creation UI. |
Hey everyone. Super excited to share after spending few hours on going through the conversations and understanding the codebase I created this PR #50401 where a issue is fixed and I believe the UX is slightly better than shown in the video by @supernovia I demonstrated the fix in a video in & commented it in my PR. Everyone's review will be highly appreciated 😊. Thanks 🙏 |
UpdateWe have new proposal for a refreshed UX and Design for the Link UI. This is to better support the various context in which it is required. |
Closing this as most of these linked issues are either completed, or tracked in the LinkControl tracking issue. Solid progress. 🚀 |
This issue captures the current priorities for the Link UI which we are aiming to include in a (near) future release of WordPress.
There's also a longer backlog used to more exhaustively track open issues, bugs, and pending tasks at #35073.
Key Problems
Design/Visual/UX
Technical
Accessibility
See this list.
Relevant Resources
The text was updated successfully, but these errors were encountered: